Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched #196

Closed
wants to merge 1 commit into from
Closed

8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched #196

wants to merge 1 commit into from

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented May 4, 2021

Clean backport from jdk15 to jdk13.
JDK17->JDK13 only one copyright year update issue


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/196/head:pull/196
$ git checkout pull/196

Update a local copy of the PR:
$ git checkout pull/196
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 196

View PR using the GUI difftool:
$ git pr show -t 196

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/196.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 4, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 020236cb9825bf4fa91a495a179623e3fcdc0149 8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched May 4, 2021
@openjdk
Copy link

openjdk bot commented May 4, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label May 4, 2021
@VladimirKempik
Copy link
Author

/clean

@openjdk openjdk bot added rfr Pull request is ready for review clean labels May 4, 2021
@openjdk
Copy link

openjdk bot commented May 4, 2021

@VladimirKempik @VladimirKempik this backport pull request is now marked as clean

@mlbridge
Copy link

mlbridge bot commented May 4, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented May 4, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8264786: [macos] All Swing/AWT apps cause Allow Notifications prompt to appear when app is launched

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 4, 2021
@VladimirKempik
Copy link
Author

/integrate

@openjdk openjdk bot closed this May 4, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 4, 2021
@openjdk
Copy link

openjdk bot commented May 4, 2021

@VladimirKempik Since your change was applied there have been 2 commits pushed to the master branch:

  • 7a23750: 8260380: Upgrade to LittleCMS 2.12
  • 1c24c09: 8264821: DirectIOTest fails on a system with large block size

Your commit was automatically rebased without conflicts.

Pushed as commit 61803a9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the backport-acf2eea2262ce78d5103afa826aa79c91298013d branch May 4, 2021 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants