Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8242184: Default signature algorithm for an RSASSA-PSS key #200

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented May 6, 2021

I'd like to backport JDK-8242184 to jdk13u for parity with jdk11u.
The original patch applied cleanly.
Tested via jtreg with "jdk/sun/security".


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8242184: Default signature algorithm for an RSASSA-PSS key

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/200/head:pull/200
$ git checkout pull/200

Update a local copy of the PR:
$ git checkout pull/200
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/200/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 200

View PR using the GUI difftool:
$ git pr show -t 200

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/200.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 6, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport d8539a51efe379cacee4093995100bf7fe23a312 8242184: Default signature algorithm for an RSASSA-PSS key May 6, 2021
@openjdk
Copy link

openjdk bot commented May 6, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 6, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8242184: Default signature algorithm for an RSASSA-PSS key

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2021
@omikhaltsova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 6, 2021
@openjdk
Copy link

openjdk bot commented May 6, 2021

@omikhaltsova
Your change (at version 4835a22) is now ready to be sponsored by a Committer.

@mlbridge
Copy link

mlbridge bot commented May 6, 2021

Webrevs

@yan-too
Copy link
Collaborator

yan-too commented May 6, 2021

/sponsor

@openjdk openjdk bot closed this May 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 6, 2021
@openjdk
Copy link

openjdk bot commented May 6, 2021

@yan-too @omikhaltsova Since your change was applied there has been 1 commit pushed to the master branch:

  • d46f297: 8231118: ARM32: Math tests failures

Your commit was automatically rebased without conflicts.

Pushed as commit fac6c49.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the backport-d8539a51 branch May 20, 2021 15:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants