Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8263676: AArch64: one potential bug in C1 LIRGenerator::generate_address() #203

Closed
wants to merge 1 commit into from
Closed

8263676: AArch64: one potential bug in C1 LIRGenerator::generate_address() #203

wants to merge 1 commit into from

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented May 7, 2021

Hi!

I'd like to backport this small fix of obvious mistake. Applies cleanly. Tested tier1 on aarch64.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263676: AArch64: one potential bug in C1 LIRGenerator::generate_address()

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/203/head:pull/203
$ git checkout pull/203

Update a local copy of the PR:
$ git checkout pull/203
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 203

View PR using the GUI difftool:
$ git pr show -t 203

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/203.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 7, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 81ba5784ba866be39612982c637b509c8205e88f 8263676: AArch64: one potential bug in C1 LIRGenerator::generate_address() May 7, 2021
@openjdk
Copy link

openjdk bot commented May 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 7, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263676: AArch64: one potential bug in C1 LIRGenerator::generate_address()

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 7, 2021
@mlbridge
Copy link

mlbridge bot commented May 7, 2021

Webrevs

@snazarkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 10, 2021
@openjdk
Copy link

openjdk bot commented May 10, 2021

@snazarkin
Your change (at version d5da99b) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented May 11, 2021

/sponsor

@openjdk openjdk bot closed this May 11, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 11, 2021
@openjdk
Copy link

openjdk bot commented May 11, 2021

@yan-too @snazarkin Since your change was applied there has been 1 commit pushed to the master branch:

  • a6f50e5: 8247763: assert(outer->outcnt() == 2) failed: 'only phis' failure in LoopNode::verify_strip_mined()

Your commit was automatically rebased without conflicts.

Pushed as commit 3671735.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the 8263676-backport branch May 12, 2021 18:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
3 participants