Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented May 12, 2021

Following discussion after https://mail.openjdk.java.net/pipermail/jdk-updates-dev/2021-May/006150.html, in addition to the original fix I have disabled gcc warninig "stringop-truncation" for lcms in Awt2dLibraries.gmk and for dt_socket in Lib-jdk.jdwp.agent.gmk.
A problem with jvmti_tools.c doesn't exist in jdk13 after JDK-8209611

Verified on Ubuntu 20.04 with gcc 9.3.0 and Ubuntu 18.04 with gcc 7.5.0, release and fastdebug builds of "images" and "test-image" targets, tier1 and separately vmTestbase tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/207/head:pull/207
$ git checkout pull/207

Update a local copy of the PR:
$ git checkout pull/207
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/207/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 207

View PR using the GUI difftool:
$ git pr show -t 207

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/207.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 11fbd78f27a338af850256a468a93dc257a4d3ac 8232084: HotSpot build failed with GCC 9.2.1 May 12, 2021
@openjdk
Copy link

openjdk bot commented May 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 12, 2021
@mlbridge
Copy link

mlbridge bot commented May 12, 2021

Webrevs

Copy link
Collaborator

@bae bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine to me.

@openjdk
Copy link

openjdk bot commented May 13, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8232084: HotSpot build failed with GCC 9.2.1

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 613eb44: 8248043: Need to eliminate excessive i2l conversions

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 13, 2021
@yan-too
Copy link
Collaborator Author

yan-too commented May 13, 2021

/integrate

@openjdk openjdk bot closed this May 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2021
@openjdk
Copy link

openjdk bot commented May 13, 2021

@yan-too Since your change was applied there has been 1 commit pushed to the master branch:

  • 613eb44: 8248043: Need to eliminate excessive i2l conversions

Your commit was automatically rebased without conflicts.

Pushed as commit c87d399.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the gcc-9-8232084 branch May 13, 2021 11:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants