Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8248043: Need to eliminate excessive i2l conversions #208

Closed
wants to merge 1 commit into from
Closed

8248043: Need to eliminate excessive i2l conversions #208

wants to merge 1 commit into from

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented May 12, 2021

Hi!

I'd like to backport this fix for parity with jdk17/11. The change improves performance slightly and covered by test.

Original patch applies cleanly. Tested by new tests and aarch64 tier1.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8248043: Need to eliminate excessive i2l conversions

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/208/head:pull/208
$ git checkout pull/208

Update a local copy of the PR:
$ git checkout pull/208
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/208/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 208

View PR using the GUI difftool:
$ git pr show -t 208

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/208.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 12, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6d137a36169956171bfd0afef91e8ce29b568e33 8248043: Need to eliminate excessive i2l conversions May 12, 2021
@openjdk
Copy link

openjdk bot commented May 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 12, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8248043: Need to eliminate excessive i2l conversions

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 4d5bb5e: 8255880: UI of Swing components is not redrawn after their internal state changed
  • 235c8ba: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
  • 3671735: 8263676: AArch64: one potential bug in C1 LIRGenerator::generate_address()
  • a6f50e5: 8247763: assert(outer->outcnt() == 2) failed: 'only phis' failure in LoopNode::verify_strip_mined()

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 12, 2021
@mlbridge
Copy link

mlbridge bot commented May 12, 2021

Webrevs

@snazarkin
Copy link
Contributor Author

snazarkin commented May 13, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 13, 2021
@openjdk
Copy link

openjdk bot commented May 13, 2021

@snazarkin
Your change (at version d151834) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented May 13, 2021

/sponsor

@openjdk openjdk bot closed this May 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 13, 2021
@openjdk
Copy link

openjdk bot commented May 13, 2021

@yan-too @snazarkin Since your change was applied there have been 4 commits pushed to the master branch:

  • 4d5bb5e: 8255880: UI of Swing components is not redrawn after their internal state changed
  • 235c8ba: 8241248: NullPointerException in sun.security.ssl.HKDF.extract(HKDF.java:93)
  • 3671735: 8263676: AArch64: one potential bug in C1 LIRGenerator::generate_address()
  • a6f50e5: 8247763: assert(outer->outcnt() == 2) failed: 'only phis' failure in LoopNode::verify_strip_mined()

Your commit was automatically rebased without conflicts.

Pushed as commit 613eb44.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the backport-8248043 branch Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants