Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8227080: (fs) Files.newInputStream(...).skip(n) is slow #210

Closed
wants to merge 1 commit into from

Conversation

Larry-N
Copy link
Contributor

@Larry-N Larry-N commented May 14, 2021

Backport JDK-8227080: (fs) Files.newInputStream(...).skip(n) is slow.
Another bug JDK-8227609 should be backported after this.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8227080: (fs) Files.newInputStream(...).skip(n) is slow

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/210/head:pull/210
$ git checkout pull/210

Update a local copy of the PR:
$ git checkout pull/210
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 210

View PR using the GUI difftool:
$ git pr show -t 210

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/210.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 14, 2021

👋 Welcome back Larry-N! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c6c82dd736db6ff96a0f82862e416a9513633cd6 8227080: (fs) Files.newInputStream(...).skip(n) is slow May 14, 2021
@openjdk
Copy link

openjdk bot commented May 14, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 14, 2021

@Larry-N This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8227080: (fs) Files.newInputStream(...).skip(n) is slow

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 14, 2021
@mlbridge
Copy link

mlbridge bot commented May 14, 2021

Webrevs

@Larry-N
Copy link
Contributor Author

Larry-N commented May 14, 2021

/integrate

@openjdk
Copy link

openjdk bot commented May 14, 2021

@Larry-N
Your change (at version 21e4f97) is now ready to be sponsored by a Committer.

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label May 14, 2021
@yan-too
Copy link
Collaborator

yan-too commented May 14, 2021

/sponsor

@openjdk openjdk bot closed this May 14, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 14, 2021
@openjdk
Copy link

openjdk bot commented May 14, 2021

@yan-too @Larry-N Pushed as commit 0b0db80.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Larry-N Larry-N deleted the backport-c6c82dd7 branch May 17, 2021 09:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants