Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8229243: SunPKCS11-Solaris provider tests failing on Solaris 11.4 #214

Closed
wants to merge 1 commit into from

Conversation

dimitryc
Copy link
Collaborator

@dimitryc dimitryc commented May 17, 2021

8229243: SunPKCS11-Solaris provider tests failing on Solaris 11.4


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8229243: SunPKCS11-Solaris provider tests failing on Solaris 11.4

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/214/head:pull/214
$ git checkout pull/214

Update a local copy of the PR:
$ git checkout pull/214
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/214/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 214

View PR using the GUI difftool:
$ git pr show -t 214

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/214.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 17, 2021

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 381e90eb6bd62416a07cf883c1588ade3287d140 8229243: SunPKCS11-Solaris provider tests failing on Solaris 11.4 May 17, 2021
@openjdk
Copy link

openjdk bot commented May 17, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented May 17, 2021

@dimitryc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8229243: SunPKCS11-Solaris provider tests failing on Solaris 11.4

For CK_GCM_PARAMS, try the spec definition first before falling back to the header file definition

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 32036b2: 8227609: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size
  • afdd824: 8249608: Vector register used by C2 compiled method corrupted at safepoint

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 17, 2021
@mlbridge
Copy link

mlbridge bot commented May 17, 2021

Webrevs

@dimitryc
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this May 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 19, 2021
@openjdk
Copy link

openjdk bot commented May 19, 2021

@dimitryc Since your change was applied there have been 7 commits pushed to the master branch:

  • 35a1646: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29
  • 9e59114: 8242010: Update IANA Language Subtag Registry to Version 2020-04-01
  • ab400f7: 8241082: Upgrade IANA Language Subtag Registry data to 03-16-2020 version
  • 23aded5: 8262829: Native crash in Win32PrintServiceLookup.getAllPrinterNames()
  • 5650831: 8241829: Cleanup the code for PrinterJob on windows
  • 32036b2: 8227609: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size
  • afdd824: 8249608: Vector register used by C2 compiled method corrupted at safepoint

Your commit was automatically rebased without conflicts.

Pushed as commit fd68584.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dimitryc dimitryc deleted the backport-8229243 branch May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant