Navigation Menu

Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8241829: Cleanup the code for PrinterJob on windows #215

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented May 19, 2021

The regular nightly testing runs OK. Applies clean. Will be ported together with 8262829 crash fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8241829: Cleanup the code for PrinterJob on windows

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/215/head:pull/215
$ git checkout pull/215

Update a local copy of the PR:
$ git checkout pull/215
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/215/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 215

View PR using the GUI difftool:
$ git pr show -t 215

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/215.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 19, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a62b24f573c418b2b30f18e72bfdb96359acc890 8241829: Cleanup the code for PrinterJob on windows May 19, 2021
@openjdk
Copy link

openjdk bot commented May 19, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 19, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8241829: Cleanup the code for PrinterJob on windows

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 32036b2: 8227609: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size
  • afdd824: 8249608: Vector register used by C2 compiled method corrupted at safepoint

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 19, 2021
@yan-too
Copy link
Collaborator Author

yan-too commented May 19, 2021

/integrate

@openjdk openjdk bot closed this May 19, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 19, 2021
@openjdk
Copy link

openjdk bot commented May 19, 2021

@yan-too Since your change was applied there have been 2 commits pushed to the master branch:

  • 32036b2: 8227609: (fs) Files.newInputStream(...).skip(n) should allow skipping beyond file size
  • afdd824: 8249608: Vector register used by C2 compiled method corrupted at safepoint

Your commit was automatically rebased without conflicts.

Pushed as commit 5650831.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the winpr-8241829 branch May 19, 2021 07:24
@mlbridge
Copy link

mlbridge bot commented May 19, 2021

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant