Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8243452: JFR: Could not create chunk in repository with over 200 recordings #221

Closed
wants to merge 1 commit into from

Conversation

@kvergizova
Copy link
Contributor

@kvergizova kvergizova commented May 19, 2021

I'd like to backport JDK-8243452 to 13u for parity with 11u.
The patch doesn't apply cleanly due to context difference in jdk/jfr/internal/RepositoryChunk.java (JDK-8244463 is not in 13u), reapplied manually.
Tested with tier1 and jdk/jfr tests; the test attached to the issue fails without the patch, passes with it.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8243452: JFR: Could not create chunk in repository with over 200 recordings

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/221/head:pull/221
$ git checkout pull/221

Update a local copy of the PR:
$ git checkout pull/221
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/221/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 221

View PR using the GUI difftool:
$ git pr show -t 221

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/221.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 19, 2021

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 6dd84434934544542137f7b7567158e067e68590 8243452: JFR: Could not create chunk in repository with over 200 recordings May 19, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented May 19, 2021

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8243452: JFR: Could not create chunk in repository with over 200 recordings

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • fd68584: 8229243: SunPKCS11-Solaris provider tests failing on Solaris 11.4
  • 35a1646: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29
  • 9e59114: 8242010: Update IANA Language Subtag Registry to Version 2020-04-01

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 19, 2021

Webrevs

Loading

@yan-too
Copy link
Collaborator

@yan-too yan-too commented May 20, 2021

apparently a number of changed lines didn't change so Skara decided it's clean: OK

Loading

@kvergizova
Copy link
Contributor Author

@kvergizova kvergizova commented May 20, 2021

/integrate

Loading

@openjdk openjdk bot closed this May 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2021

@kvergizova Since your change was applied there have been 5 commits pushed to the master branch:

  • 32f107a: 8252883: AccessDeniedException caused by delayed file deletion on Windows
  • 9fe778e: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files
  • fd68584: 8229243: SunPKCS11-Solaris provider tests failing on Solaris 11.4
  • 35a1646: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29
  • 9e59114: 8242010: Update IANA Language Subtag Registry to Version 2020-04-01

Your commit was automatically rebased without conflicts.

Pushed as commit e7fc201.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@kvergizova kvergizova deleted the backport-8243452 branch Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants