Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8229396: jdeps ignores multi-release when generate-module-info used on command line #223

Closed
wants to merge 1 commit into from

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented May 20, 2021

should be fixed here, too, together with 8225773. jdeps tests run OK.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8229396: jdeps ignores multi-release when generate-module-info used on command line

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/223/head:pull/223
$ git checkout pull/223

Update a local copy of the PR:
$ git checkout pull/223
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/223/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 223

View PR using the GUI difftool:
$ git pr show -t 223

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/223.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented May 20, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b7e74ef62f4797d30a6edc5c7963f309b11b067d 8229396: jdeps ignores multi-release when generate-module-info used on command line May 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8229396: jdeps ignores multi-release when generate-module-info used on command line

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented May 20, 2021

/integrate

@openjdk openjdk bot closed this May 20, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels May 20, 2021
@openjdk
Copy link

@openjdk openjdk bot commented May 20, 2021

@yan-too Pushed as commit d103e2e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

@mlbridge mlbridge bot commented May 20, 2021

Webrevs

@yan-too yan-too deleted the jdeps-8229396 branch May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant