-
Notifications
You must be signed in to change notification settings - Fork 25
8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash #226
Conversation
|
👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
@VladimirKempik This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 32 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
a74nh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How is this bug being produced? Are you building for the arm64e target? As I understood it, jdk is only built for the arm64 target.
|
/integrate |
|
@VladimirKempik Since your change was applied there have been 32 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit dd8262d. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This issue affects all aarch64 platforms, but to make java crash the platform need to pac-sign LR register, on the rest of aarch64 platform it effectively NO-OP
Applies clean
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/226/head:pull/226$ git checkout pull/226Update a local copy of the PR:
$ git checkout pull/226$ git pull https://git.openjdk.java.net/jdk13u-dev pull/226/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 226View PR using the GUI difftool:
$ git pr show -t 226Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/226.diff