Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented May 21, 2021

This issue affects all aarch64 platforms, but to make java crash the platform need to pac-sign LR register, on the rest of aarch64 platform it effectively NO-OP
Applies clean


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/226/head:pull/226
$ git checkout pull/226

Update a local copy of the PR:
$ git checkout pull/226
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/226/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 226

View PR using the GUI difftool:
$ git pr show -t 226

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/226.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 21, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport ca93399af103384e750dabf3abcc6e8392bcf3f4 8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash May 21, 2021
@openjdk
Copy link

openjdk bot commented May 21, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented May 21, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267235: [macos_aarch64] InterpreterRuntime::throw_pending_exception messing up LR results in crash

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 32 new commits pushed to the master branch:

  • ebb6843: 8225773: jdeps --check produces NPE if there is any missing module dependence
  • d103e2e: 8229396: jdeps ignores multi-release when generate-module-info used on command line
  • 5cae7b2: 8216012: Infinite loop in RSA KeyPairGenerator
  • e7fc201: 8243452: JFR: Could not create chunk in repository with over 200 recordings
  • 32f107a: 8252883: AccessDeniedException caused by delayed file deletion on Windows
  • 9fe778e: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files
  • fd68584: 8229243: SunPKCS11-Solaris provider tests failing on Solaris 11.4
  • 35a1646: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29
  • 9e59114: 8242010: Update IANA Language Subtag Registry to Version 2020-04-01
  • ab400f7: 8241082: Upgrade IANA Language Subtag Registry data to 03-16-2020 version
  • ... and 22 more: https://git.openjdk.java.net/jdk13u-dev/compare/da3c598a4d149b20b256520738981597c835b4af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 21, 2021
@mlbridge
Copy link

mlbridge bot commented May 21, 2021

Webrevs

Copy link

@a74nh a74nh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is this bug being produced? Are you building for the arm64e target? As I understood it, jdk is only built for the arm64 target.

@VladimirKempik
Copy link
Author

/integrate

@openjdk openjdk bot closed this May 21, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated labels May 21, 2021
@openjdk
Copy link

openjdk bot commented May 21, 2021

@VladimirKempik Since your change was applied there have been 32 commits pushed to the master branch:

  • ebb6843: 8225773: jdeps --check produces NPE if there is any missing module dependence
  • d103e2e: 8229396: jdeps ignores multi-release when generate-module-info used on command line
  • 5cae7b2: 8216012: Infinite loop in RSA KeyPairGenerator
  • e7fc201: 8243452: JFR: Could not create chunk in repository with over 200 recordings
  • 32f107a: 8252883: AccessDeniedException caused by delayed file deletion on Windows
  • 9fe778e: 8244154: Update SunPKCS11 provider with PKCS11 v3.0 header files
  • fd68584: 8229243: SunPKCS11-Solaris provider tests failing on Solaris 11.4
  • 35a1646: 8247432: Update IANA Language Subtag Registry to Version 2020-09-29
  • 9e59114: 8242010: Update IANA Language Subtag Registry to Version 2020-04-01
  • ab400f7: 8241082: Upgrade IANA Language Subtag Registry data to 03-16-2020 version
  • ... and 22 more: https://git.openjdk.java.net/jdk13u-dev/compare/da3c598a4d149b20b256520738981597c835b4af...master

Your commit was automatically rebased without conflicts.

Pushed as commit dd8262d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@openjdk openjdk bot removed the rfr Pull request is ready for review label May 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants