Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8235368: Update BCEL to Version 6.4.1 #227

Closed
wants to merge 1 commit into from

Conversation

dimitryc
Copy link
Collaborator

@dimitryc dimitryc commented May 25, 2021

8235368: Update BCEL to Version 6.4.1

Applies cleanly except @lastmodified timestamps in two files below (due to JDK-8248348 with newer timestamps is already included in 13u)

src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/BranchInstruction.java
src/java.xml/share/classes/com/sun/org/apache/bcel/internal/generic/Instruction.java


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/227/head:pull/227
$ git checkout pull/227

Update a local copy of the PR:
$ git checkout pull/227
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/227/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 227

View PR using the GUI difftool:
$ git pr show -t 227

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/227.diff

@bridgekeeper
Copy link

bridgekeeper bot commented May 25, 2021

👋 Welcome back dcherepanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e8f8eef9087c2be14bb1726cf9892517581067cd 8235368: Update BCEL to Version 6.4.1 May 25, 2021
@openjdk
Copy link

openjdk bot commented May 25, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels May 25, 2021
@mlbridge
Copy link

mlbridge bot commented May 25, 2021

Webrevs

Copy link
Collaborator

@yan-too yan-too left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me!

@openjdk
Copy link

openjdk bot commented May 26, 2021

@dimitryc This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8235368: Update BCEL to Version 6.4.1

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 26, 2021
@dimitryc
Copy link
Collaborator Author

/integrate

@openjdk openjdk bot closed this May 26, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 26, 2021
@openjdk
Copy link

openjdk bot commented May 26, 2021

@dimitryc Pushed as commit cea44d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@dimitryc dimitryc deleted the backport-8235368 branch May 26, 2021 10:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants