Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4 #235

Closed
wants to merge 1 commit into from

Conversation

@VladimirKempik
Copy link
Contributor

@VladimirKempik VladimirKempik commented Jul 27, 2021

Almost clean backport to jdk13u-dev. only different filename for gmk file in jdk13 mde it not apply clean ootb.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/235/head:pull/235
$ git checkout pull/235

Update a local copy of the PR:
$ git checkout pull/235
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/235/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 235

View PR using the GUI difftool:
$ git pr show -t 235

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/235.diff

@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Jul 27, 2021

/clean

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 27, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jul 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

@VladimirKempik @VladimirKempik can only mark backport pull requests, with an original hash, as clean

@VladimirKempik VladimirKempik changed the title 8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4 Backport 3bb6a3d2ab96373baa4e18f4e61173f11225fd4e Jul 27, 2021
@openjdk openjdk bot changed the title Backport 3bb6a3d2ab96373baa4e18f4e61173f11225fd4e 8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4 Jul 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jul 27, 2021
@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Jul 27, 2021

/clean

@openjdk openjdk bot added the clean label Jul 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

@VladimirKempik @VladimirKempik this backport pull request is now marked as clean

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 27, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8261109: [macOS] Remove disabled warning for JNF in make/autoconf/flags-cflags.m4

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jul 27, 2021
@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Jul 27, 2021

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

Going to push as commit 6d7e176.

@openjdk openjdk bot closed this Jul 27, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 27, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 27, 2021

@VladimirKempik Pushed as commit 6d7e176.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the JDK-8261109 branch Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants