Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8253899: Make IsClassUnloadingEnabled signature match specification #236

Closed
wants to merge 1 commit into from
Closed

8253899: Make IsClassUnloadingEnabled signature match specification #236

wants to merge 1 commit into from

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Jul 27, 2021

Backport for csr JDK-8268256, applies almost clean for 13u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8253899: Make IsClassUnloadingEnabled signature match specification

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/236/head:pull/236
$ git checkout pull/236

Update a local copy of the PR:
$ git checkout pull/236
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/236/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 236

View PR using the GUI difftool:
$ git pr show -t 236

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/236.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 27, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c7f00640627eab38b77d23d07876cf0247fa18f3 8253899: Make IsClassUnloadingEnabled signature match specification Jul 27, 2021
@openjdk
Copy link

openjdk bot commented Jul 27, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 27, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253899: Make IsClassUnloadingEnabled signature match specification

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 27, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 27, 2021

Webrevs

@VladimirKempik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 27, 2021

Going to push as commit 70ff422.

@openjdk openjdk bot closed this Jul 27, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 27, 2021
@openjdk
Copy link

openjdk bot commented Jul 27, 2021

@VladimirKempik Pushed as commit 70ff422.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@VladimirKempik VladimirKempik deleted the JDK-8253899 branch July 27, 2021 14:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant