Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8263361: Incorrect arraycopy stub selected by C2 for SATB collectors #238

Closed
wants to merge 1 commit into from
Closed

8263361: Incorrect arraycopy stub selected by C2 for SATB collectors #238

wants to merge 1 commit into from

Conversation

snazarkin
Copy link

@snazarkin snazarkin commented Jul 28, 2021

I'd like to backport this patch that fixes hotspot debug builds crash. The patch is required for further activity to keep backports clean. The changes are taken from jdk15 and requires some manual intervention at src/hotspot/share/opto/library_call.cpp due to missed 8235653 (it removes line with obj = access_resolve(obj, ACCESS_READ);).

I've not touched 8235653 because its low priority and dependency on a set of other commits


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8263361: Incorrect arraycopy stub selected by C2 for SATB collectors

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/238/head:pull/238
$ git checkout pull/238

Update a local copy of the PR:
$ git checkout pull/238
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/238/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 238

View PR using the GUI difftool:
$ git pr show -t 238

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/238.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 28, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5d87a21991b964e1c50495dc2dc982db425830b5 8263361: Incorrect arraycopy stub selected by C2 for SATB collectors Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Jul 28, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 28, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8263361: Incorrect arraycopy stub selected by C2 for SATB collectors

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • dd3d55e: 8172404: Tools should warn if weak algorithms are used before restricting them

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Jul 28, 2021
@snazarkin
Copy link
Author

@snazarkin snazarkin commented Jul 28, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@snazarkin
Your change (at version e409457) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Jul 28, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

Going to push as commit 4d40fee.
Since your change was applied there has been 1 commit pushed to the master branch:

  • dd3d55e: 8172404: Tools should warn if weak algorithms are used before restricting them

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@yan-too @snazarkin Pushed as commit 4d40fee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the 8263361-backport branch Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants