Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8191278: MappedByteBuffer bulk access memory failures are not handled gracefully #239

Closed
wants to merge 2 commits into from
Closed

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented Jul 28, 2021

I'd like to backport this changes to fix crash happens on memory mapped file operations. The patch applies cleanly after #238.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8191278: MappedByteBuffer bulk access memory failures are not handled gracefully

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/239/head:pull/239
$ git checkout pull/239

Update a local copy of the PR:
$ git checkout pull/239
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/239/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 239

View PR using the GUI difftool:
$ git pr show -t 239

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/239.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 28, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport aedbb7580334cb9131f547845f9b7aa3916ddf4b 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully Jul 28, 2021
@openjdk
Copy link

openjdk bot commented Jul 28, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jul 28, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 28, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jul 28, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8191278: MappedByteBuffer bulk access memory failures are not handled gracefully

Unsafe.copy*Memory access failures are handled gracefully.

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 4d40fee: 8263361: Incorrect arraycopy stub selected by C2 for SATB collectors
  • dd3d55e: 8172404: Tools should warn if weak algorithms are used before restricting them

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 28, 2021
@snazarkin snazarkin closed this Jul 28, 2021
@snazarkin snazarkin deleted the 8191278-backport branch July 28, 2021 12:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport ready Pull request is ready to be integrated rfr Pull request is ready for review
2 participants