Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8257620: Do not use objc_msgSend_stret to get macOS version #241

Conversation

@VladimirKempik
Copy link
Contributor

@VladimirKempik VladimirKempik commented Jul 28, 2021

Applies cleanly, patch needed for zero+mac+aarch64 config


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8257620: Do not use objc_msgSend_stret to get macOS version

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/241/head:pull/241
$ git checkout pull/241

Update a local copy of the PR:
$ git checkout pull/241
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/241/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 241

View PR using the GUI difftool:
$ git pr show -t 241

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/241.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jul 28, 2021

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport d4c7db5060978302382549246f9ad6831f19377d 8257620: Do not use objc_msgSend_stret to get macOS version Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@VladimirKempik This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8257620: Do not use objc_msgSend_stret to get macOS version

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jul 28, 2021

Webrevs

Loading

@VladimirKempik
Copy link
Contributor Author

@VladimirKempik VladimirKempik commented Jul 28, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

Going to push as commit 6dd4098.

Loading

@openjdk openjdk bot closed this Jul 28, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jul 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jul 28, 2021

@VladimirKempik Pushed as commit 6dd4098.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant