Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8226878: zero crashes after JDK-8191278 #243

Closed
wants to merge 1 commit into from
Closed

8226878: zero crashes after JDK-8191278 #243

wants to merge 1 commit into from

Conversation

snazarkin
Copy link

@snazarkin snazarkin commented Jul 29, 2021

This is follow up for #240 and required to build zero binaries.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/243/head:pull/243
$ git checkout pull/243

Update a local copy of the PR:
$ git checkout pull/243
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/243/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 243

View PR using the GUI difftool:
$ git pr show -t 243

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/243.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 302b8d06ce595b6071d728f6ab10dde561dcd54b 8226878: zero crashes after JDK-8191278 Jul 29, 2021
@openjdk
Copy link

openjdk bot commented Jul 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8226878: zero crashes after JDK-8191278

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 0cac580: 8258373: Update the text handling in the JPasswordField
  • 6dd4098: 8257620: Do not use objc_msgSend_stret to get macOS version

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Jul 29, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2021

Webrevs

@snazarkin
Copy link
Author

snazarkin commented Jul 29, 2021

/integrate

@openjdk openjdk bot added the sponsor label Jul 29, 2021
@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@snazarkin
Your change (at version 60eb9fd) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Jul 29, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 29, 2021

Going to push as commit 44980ee.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 82ef189: 8226871: invalid use of incomplete type class MacroAssembler when building minimal after JDK-8191278
  • 40ab2a0: 8191278: MappedByteBuffer bulk access memory failures are not handled gracefully
  • 0cac580: 8258373: Update the text handling in the JPasswordField
  • 6dd4098: 8257620: Do not use objc_msgSend_stret to get macOS version

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Jul 29, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Jul 29, 2021
@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@yan-too @snazarkin Pushed as commit 44980ee.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the 8226878-backport branch Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants