Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8229254: solaris_x64 build fails after JDK-8191278 #245

Closed
wants to merge 1 commit into from
Closed

8229254: solaris_x64 build fails after JDK-8191278 #245

wants to merge 1 commit into from

Conversation

snazarkin
Copy link
Contributor

@snazarkin snazarkin commented Jul 29, 2021

This is follow up for JDK-8191278. Applies cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8229254: solaris_x64 build fails after JDK-8191278

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/245/head:pull/245
$ git checkout pull/245

Update a local copy of the PR:
$ git checkout pull/245
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/245/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 245

View PR using the GUI difftool:
$ git pr show -t 245

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/245.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9e633ae0657897636a4ade580a7a2e9844252389 8229254: solaris_x64 build fails after JDK-8191278 Jul 29, 2021
@openjdk
Copy link

openjdk bot commented Jul 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 29, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8229254: solaris_x64 build fails after JDK-8191278

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 9186ec9: 8268775: Password is being converted to String in AccessibleJPasswordField
  • b3236af: 8254967: com.sun.net.HttpsServer spins on TLS session close
  • 44980ee: 8226878: zero crashes after JDK-8191278
  • 82ef189: 8226871: invalid use of incomplete type class MacroAssembler when building minimal after JDK-8191278

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 29, 2021
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2021

Webrevs

@snazarkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 3, 2021
@openjdk
Copy link

openjdk bot commented Aug 3, 2021

@snazarkin
Your change (at version a2656c7) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Aug 20, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 20, 2021

Going to push as commit 2ce2565.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 9fe8588: 8215712: Parsing extension failure may alert decode_error
  • 481b6f8: 8254631: Better support ALPN byte wire values in SunJSSE
  • 9940295: 8241888: Mirror jdk.security.allowNonCaAnchor system property with a security one
  • 7a64454: 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type
  • 9186ec9: 8268775: Password is being converted to String in AccessibleJPasswordField
  • b3236af: 8254967: com.sun.net.HttpsServer spins on TLS session close
  • 44980ee: 8226878: zero crashes after JDK-8191278
  • 82ef189: 8226871: invalid use of incomplete type class MacroAssembler when building minimal after JDK-8191278

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@yan-too @snazarkin Pushed as commit 2ce2565.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the 8229254-backport branch October 22, 2021 11:21
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants