Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8267625: AARCH64: typo in LIR_Assembler::emit_profile_type #248

Closed
wants to merge 1 commit into from
Closed

8267625: AARCH64: typo in LIR_Assembler::emit_profile_type #248

wants to merge 1 commit into from

Conversation

snazarkin
Copy link

@snazarkin snazarkin commented Aug 3, 2021

A clean backport for parity with JDK11/17


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8267625: AARCH64: typo in LIR_Assembler::emit_profile_type

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/248/head:pull/248
$ git checkout pull/248

Update a local copy of the PR:
$ git checkout pull/248
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/248/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 248

View PR using the GUI difftool:
$ git pr show -t 248

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/248.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Aug 3, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 3d090e7ee561252027c06021b337c69a39f724e1 8267625: AARCH64: typo in LIR_Assembler::emit_profile_type Aug 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8267625: AARCH64: typo in LIR_Assembler::emit_profile_type

Reviewed-by: aph

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@theRealAph) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Aug 3, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Aug 3, 2021

Webrevs

@snazarkin
Copy link
Author

@snazarkin snazarkin commented Aug 3, 2021

/integrate

@openjdk openjdk bot added the sponsor label Aug 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@snazarkin
Your change (at version 5306ae8) is now ready to be sponsored by a Committer.

@dimitryc
Copy link
Collaborator

@dimitryc dimitryc commented Aug 3, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

Going to push as commit 7a64454.

@openjdk openjdk bot closed this Aug 3, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Aug 3, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Aug 3, 2021

@dimitryc @snazarkin Pushed as commit 7a64454.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the 8267625-backport branch Aug 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
3 participants