Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8241888: Mirror jdk.security.allowNonCaAnchor system property with a security one #249

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Aug 5, 2021

The original patch applies almost clean: trivial fix in java.security because of jdk.jndi.object.factoriesFilter property already backported into 13u
Tests in jdk/sun/security/validator passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8241888: Mirror jdk.security.allowNonCaAnchor system property with a security one

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/249/head:pull/249
$ git checkout pull/249

Update a local copy of the PR:
$ git checkout pull/249
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/249/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 249

View PR using the GUI difftool:
$ git pr show -t 249

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/249.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 5, 2021

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1c651455a75ff21770bb3b112a440396fce402a5 8241888: Mirror jdk.security.allowNonCaAnchor system property with a security one Aug 5, 2021
@openjdk
Copy link

openjdk bot commented Aug 5, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 5, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 5, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8241888: Mirror jdk.security.allowNonCaAnchor system property with a security one

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dimitryc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 9, 2021
@alexeybakhtin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 9, 2021
@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@alexeybakhtin
Your change (at version 5be2290) is now ready to be sponsored by a Committer.

@dimitryc
Copy link
Collaborator

dimitryc commented Aug 9, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 9, 2021

Going to push as commit 9940295.

@openjdk openjdk bot closed this Aug 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 9, 2021
@openjdk
Copy link

openjdk bot commented Aug 9, 2021

@dimitryc @alexeybakhtin Pushed as commit 9940295.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants