Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8206925: Support the certificate_authorities extension #252

Closed
wants to merge 1 commit into from

Conversation

alexeybakhtin
Copy link
Contributor

@alexeybakhtin alexeybakhtin commented Aug 12, 2021

I'd like to backport it to 13u as soon as it is in 8u and 11u already
Applied cleanly
All sun/security/ssl javax/net/ssl tests (including 3 new tests) are passed


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8206925: Support the certificate_authorities extension

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/252/head:pull/252
$ git checkout pull/252

Update a local copy of the PR:
$ git checkout pull/252
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/252/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 252

View PR using the GUI difftool:
$ git pr show -t 252

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/252.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2021

👋 Welcome back abakhtin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 17a298962c35d5c8ebae73fdb8a969139551b5a7 8206925: Support the certificate_authorities extension Aug 12, 2021
@openjdk
Copy link

openjdk bot commented Aug 12, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 12, 2021

@alexeybakhtin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8206925: Support the certificate_authorities extension

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2ce2565: 8229254: solaris_x64 build fails after JDK-8191278

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 12, 2021
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2021

Webrevs

@alexeybakhtin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@alexeybakhtin
Your change (at version 19752fd) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Aug 20, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 20, 2021

Going to push as commit 239e727.
Since your change was applied there have been 2 commits pushed to the master branch:

  • c8350fc: 8272602: [macos] not all KEY_PRESSED events sent when control modifier is used
  • 2ce2565: 8229254: solaris_x64 build fails after JDK-8191278

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Aug 20, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 20, 2021
@openjdk
Copy link

openjdk bot commented Aug 20, 2021

@yan-too @alexeybakhtin Pushed as commit 239e727.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants