Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8270317: Large Allocation in CipherSuite #257

Conversation

cliveverghese
Copy link
Contributor

@cliveverghese cliveverghese commented Sep 3, 2021

Hi all,

This pull request contains a backport of commit e627caec from the openjdk/jdk repository.

The commit being backported was authored by Clive Verghese on 24 Jul 2021 and was reviewed by Xue-Lei Andrew Fan and Volker Simonis.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/257/head:pull/257
$ git checkout pull/257

Update a local copy of the PR:
$ git checkout pull/257
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/257/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 257

View PR using the GUI difftool:
$ git pr show -t 257

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/257.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 3, 2021

👋 Welcome back cverghese! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport e627caec84c169c99c04e0d355c29b806a0266ed 8270317: Large Allocation in CipherSuite Sep 3, 2021
@openjdk
Copy link

openjdk bot commented Sep 3, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 3, 2021

@cliveverghese This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8270317: Large Allocation in CipherSuite

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 3, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 3, 2021

Webrevs

@cliveverghese
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 9, 2021
@openjdk
Copy link

openjdk bot commented Sep 9, 2021

@cliveverghese
Your change (at version 6c78380) is now ready to be sponsored by a Committer.

@phohensee
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 9, 2021

Going to push as commit 0b2d2a1.

@openjdk openjdk bot closed this Sep 9, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 9, 2021
@openjdk
Copy link

openjdk bot commented Sep 9, 2021

@phohensee @cliveverghese Pushed as commit 0b2d2a1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants