This repository was archived by the owner on Feb 2, 2023. It is now read-only.
8259271: gc/parallel/TestDynShrinkHeap.java still fails "assert(covered_region.contains(new_memregion)) failed: new region is not in covered_region" #263
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to backport JDK-8259271 to jdk13u for parity with jdk11u.
The original patch applied manually. The patch is absolutely identical to the jdk11u patch, it also uses OrderAccess instead of Atomic because the method was moved from OrderAccess to Atomic only in JDK 14 with JDK-8234562. It's the only difference with the original patch.
All regular tests passed.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/263/head:pull/263
$ git checkout pull/263
Update a local copy of the PR:
$ git checkout pull/263
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/263/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 263
View PR using the GUI difftool:
$ git pr show -t 263
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/263.diff