Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259271: gc/parallel/TestDynShrinkHeap.java still fails "assert(covered_region.contains(new_memregion)) failed: new region is not in covered_region" #263

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Sep 17, 2021

I'd like to backport JDK-8259271 to jdk13u for parity with jdk11u.
The original patch applied manually. The patch is absolutely identical to the jdk11u patch, it also uses OrderAccess instead of Atomic because the method was moved from OrderAccess to Atomic only in JDK 14 with JDK-8234562. It's the only difference with the original patch.
All regular tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259271: gc/parallel/TestDynShrinkHeap.java still fails "assert(covered_region.contains(new_memregion)) failed: new region is not in covered_region"

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/263/head:pull/263
$ git checkout pull/263

Update a local copy of the PR:
$ git checkout pull/263
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/263/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 263

View PR using the GUI difftool:
$ git pr show -t 263

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/263.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 17, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 685c03dc4899e4f43e830d516b751969ed20ec21 8259271: gc/parallel/TestDynShrinkHeap.java still fails "assert(covered_region.contains(new_memregion)) failed: new region is not in covered_region" Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 17, 2021
@mlbridge
Copy link

mlbridge bot commented Sep 17, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8259271: gc/parallel/TestDynShrinkHeap.java still fails "assert(covered_region.contains(new_memregion)) failed: new region is not in covered_region"

Use load_acquire to order reads of top and end.

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 17, 2021
@omikhaltsova
Copy link
Contributor Author

omikhaltsova commented Sep 17, 2021

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@omikhaltsova
Your change (at version 758b897) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Sep 17, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 17, 2021

Going to push as commit 49355ef.

@openjdk openjdk bot closed this Sep 17, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 17, 2021
@openjdk
Copy link

openjdk bot commented Sep 17, 2021

@yan-too @omikhaltsova Pushed as commit 49355ef.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the backport-685c03dc branch Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
2 participants