Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8185005: Improve performance of ThreadMXBean.getThreadInfo(long ids[], int maxDepth) #266

Closed
wants to merge 3 commits into from
Closed

Conversation

@snazarkin
Copy link

@snazarkin snazarkin commented Sep 28, 2021

I'd like to backport this case for parity with jdk11. The patch need some fixes similar to described here http://mail.openjdk.java.net/pipermail/jdk-updates-dev/2020-January/002377.html, except move of primitive_hash is not necessary.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8185005: Improve performance of ThreadMXBean.getThreadInfo(long ids[], int maxDepth)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/266/head:pull/266
$ git checkout pull/266

Update a local copy of the PR:
$ git checkout pull/266
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/266/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 266

View PR using the GUI difftool:
$ git pr show -t 266

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/266.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 28, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6ccf3351d7eef4b6a2ef8b33e4173416cfdcefd5 8185005: Improve performance of ThreadMXBean.getThreadInfo(long ids[], int maxDepth) Sep 28, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

This backport pull request has now been updated with issue from the original commit.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 28, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Sep 28, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8185005: Improve performance of ThreadMXBean.getThreadInfo(long ids[], int maxDepth)

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 8c39504: 8273358: macOS Monterey does not have the font Times needed by Serif
  • c96f1a0: 8274056: JavaAccessibilityUtilities leaks JNI objects

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Sep 28, 2021
@snazarkin
Copy link
Author

@snazarkin snazarkin commented Oct 1, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@snazarkin
Your change (at version 916282d) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Oct 1, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

Going to push as commit 42c55e7.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 8c39504: 8273358: macOS Monterey does not have the font Times needed by Serif
  • c96f1a0: 8274056: JavaAccessibilityUtilities leaks JNI objects

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Oct 1, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 1, 2021

@yan-too @snazarkin Pushed as commit 42c55e7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@snazarkin snazarkin deleted the 8185005-backport branch Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants