Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8274381: missing CAccessibility definitions in JNI code #269

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Oct 6, 2021

I'd like to backport JDK-8274381 to jdk13u. It's a followup for JDK-8274056 that has been already back ported to jdk13u.
The original patch applied partially because there is no CommonComponentAccessibility.m. This patch is absolutely identical to that one applied to jdk17u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8274381: missing CAccessibility definitions in JNI code

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/269/head:pull/269
$ git checkout pull/269

Update a local copy of the PR:
$ git checkout pull/269
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/269/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 269

View PR using the GUI difftool:
$ git pr show -t 269

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/269.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 6, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport be4037374520917d5a0ed54eebb3d5d6d100d429 8274381: missing CAccessibility definitions in JNI code Oct 6, 2021
@openjdk
Copy link

openjdk bot commented Oct 6, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Oct 6, 2021
@mlbridge
Copy link

mlbridge bot commented Oct 6, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 6, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8274381: missing CAccessibility definitions in JNI code

Reviewed-by: yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Oct 6, 2021
@omikhaltsova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 6, 2021
@openjdk
Copy link

openjdk bot commented Oct 6, 2021

@omikhaltsova
Your change (at version 645eaaa) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Oct 6, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 6, 2021

Going to push as commit cb4e2d6.

@openjdk openjdk bot closed this Oct 6, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 6, 2021
@openjdk
Copy link

openjdk bot commented Oct 6, 2021

@yan-too @omikhaltsova Pushed as commit cb4e2d6.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@omikhaltsova omikhaltsova deleted the backport-be403737 branch December 16, 2021 15:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants