Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8210977: jdk/jfr/event/oldobject/TestThreadLocalLeak.java fails to find ThreadLocalObject #27

Closed
wants to merge 1 commit into from

Conversation

kvergizova
Copy link
Contributor

@kvergizova kvergizova commented Nov 25, 2020

I'd like to backport 8210977 to 13u. This is a test only change that increases tests stability.
The original patch applies cleanly.
The affected test passes.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8210977: jdk/jfr/event/oldobject/TestThreadLocalLeak.java fails to find ThreadLocalObject

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/27/head:pull/27
$ git checkout pull/27

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 25, 2020

👋 Welcome back evergizova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport f3cd52e3c73ad525456a20b5190a3a97e862ec15 8210977: jdk/jfr/event/oldobject/TestThreadLocalLeak.java fails to find ThreadLocalObject Nov 25, 2020
@openjdk
Copy link

openjdk bot commented Nov 25, 2020

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Nov 25, 2020

@kvergizova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8210977: jdk/jfr/event/oldobject/TestThreadLocalLeak.java fails to find ThreadLocalObject

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 4623f5a: 8241138: http.nonProxyHosts=* causes StringIndexOutOfBoundsException in DefaultProxySelector
  • 538464b: 8238579: HttpsURLConnection drops the timeout and hangs forever in read
  • a5c8624: 8244621: [macos10.15] Garbled FX printing plus CoreText warnings on Catalina when building with Xcode 11
  • 09ed2f5: 8233452: java.math.BigDecimal.sqrt() with RoundingMode.FLOOR results in incorrect result

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Nov 25, 2020
@mlbridge
Copy link

mlbridge bot commented Nov 25, 2020

Webrevs

@kvergizova
Copy link
Contributor Author

kvergizova commented Nov 25, 2020

/integrate

@openjdk openjdk bot added the sponsor label Nov 25, 2020
@openjdk
Copy link

openjdk bot commented Nov 25, 2020

@kvergizova
Your change (at version acada08) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Nov 26, 2020

/sponsor

@openjdk openjdk bot closed this Nov 26, 2020
@openjdk openjdk bot added integrated and removed sponsor ready rfr labels Nov 26, 2020
@openjdk
Copy link

openjdk bot commented Nov 26, 2020

@yan-too @kvergizova Since your change was applied there have been 4 commits pushed to the master branch:

  • 4623f5a: 8241138: http.nonProxyHosts=* causes StringIndexOutOfBoundsException in DefaultProxySelector
  • 538464b: 8238579: HttpsURLConnection drops the timeout and hangs forever in read
  • a5c8624: 8244621: [macos10.15] Garbled FX printing plus CoreText warnings on Catalina when building with Xcode 11
  • 09ed2f5: 8233452: java.math.BigDecimal.sqrt() with RoundingMode.FLOOR results in incorrect result

Your commit was automatically rebased without conflicts.

Pushed as commit e9fdf00.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@kvergizova kvergizova deleted the backport-8210977 branch Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants