Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8239334: Tab Size does not work correctly in JTextArea with setLineWrap on #272

Closed
wants to merge 1 commit into from

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Oct 18, 2021

Should be ported in 13 for parity with 11


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8239334: Tab Size does not work correctly in JTextArea with setLineWrap on

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/272/head:pull/272
$ git checkout pull/272

Update a local copy of the PR:
$ git checkout pull/272
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/272/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 272

View PR using the GUI difftool:
$ git pr show -t 272

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/272.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 18, 2021

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot changed the title Backport 3c72042627a02c2ad12a909fc76a082d902bc35d 8239334: Tab Size does not work correctly in JTextArea with setLineWrap on Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

This backport pull request has now been updated with issue from the original commit.

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8239334: Tab Size does not work correctly in JTextArea with setLineWrap on

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Oct 18, 2021

/integrate

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

Going to push as commit f5c51d9.

Loading

@openjdk openjdk bot closed this Oct 18, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Oct 18, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 18, 2021

@yan-too Pushed as commit f5c51d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 18, 2021

Webrevs

Loading

@yan-too yan-too deleted the b8239334 branch Oct 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant