Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8230307: ZGC: Make zGlobals and zArguments OS agnostic #280

Closed
wants to merge 2 commits into from
Closed

8230307: ZGC: Make zGlobals and zArguments OS agnostic #280

wants to merge 2 commits into from

Conversation

snazarkin
Copy link

@snazarkin snazarkin commented Oct 22, 2021

Clean backport as prerequisite for JDK-8216557. Tested with tier1


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8230307: ZGC: Make zGlobals and zArguments OS agnostic

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/280/head:pull/280
$ git checkout pull/280

Update a local copy of the PR:
$ git checkout pull/280
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/280/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 280

View PR using the GUI difftool:
$ git pr show -t 280

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/280.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Oct 22, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 277ef756c4d2250047af05b3f13d8c86fe611ed4 8230307: ZGC: Make zGlobals and zArguments OS agnostic Oct 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Oct 22, 2021
@openjdk openjdk bot added the clean label Oct 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8230307: ZGC: Make zGlobals and zArguments OS agnostic

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Oct 22, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Oct 22, 2021

Webrevs

@snazarkin
Copy link
Author

@snazarkin snazarkin commented Oct 22, 2021

/integrate

@openjdk openjdk bot added the sponsor label Oct 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2021

@snazarkin
Your change (at version 597f223) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Oct 22, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2021

Going to push as commit f400e59.

@openjdk openjdk bot closed this Oct 22, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Oct 22, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Oct 22, 2021

@yan-too @snazarkin Pushed as commit f400e59.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants