8270533: AArch64: size_fits_all_mem_uses should return false if its output is a CAS #287
Conversation
👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@apavlyutkin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 40 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@apavlyutkin |
/sponsor |
Going to push as commit e3887aa.
Your commit was automatically rebased without conflicts. |
@yan-too @apavlyutkin Pushed as commit e3887aa. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I'd like to backport JDK-8190753 to jdk13u
The fix prevents using a result of Shift-n-Add operation as an input for CAS operation that takes only register operands for Aarch64
The original patch applied cleanly
Testing: original patch does not have verification tests. Regression: hotspot_all (arm64/20.04 LTS)
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/287/head:pull/287
$ git checkout pull/287
Update a local copy of the PR:
$ git checkout pull/287
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/287/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 287
View PR using the GUI difftool:
$ git pr show -t 287
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/287.diff