-
Notifications
You must be signed in to change notification settings - Fork 28
8274293: Build failure on macOS with Xcode 13.0 as vfork is deprecated #292
Conversation
👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/integrate |
@omikhaltsova This pull request has not yet been marked as ready for integration. |
@omikhaltsova This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 2 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@omikhaltsova |
/integrate |
@omikhaltsova |
/sponsor |
Going to push as commit e1b5440.
Your commit was automatically rebased without conflicts. |
@yan-too @omikhaltsova Pushed as commit e1b5440. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I'd like to backport JDK-8274293 to jdk13u for parity with jdk11u.
The same issue is observed on macOS Monterey 12.0.1 while compiling with Xcode 13.0 (--disable-warnings-as-errors is used because it's not the only issue at the moment):
The original patch applied partially and manually because os_posix.cpp doesn't need any fixes due to JDK-8262955 is not included to jdk13u. This patch is absolutely identical to that one applied to jdk11u.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/292/head:pull/292
$ git checkout pull/292
Update a local copy of the PR:
$ git checkout pull/292
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/292/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 292
View PR using the GUI difftool:
$ git pr show -t 292
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/292.diff