Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873 #298

Closed
wants to merge 1 commit into from

Conversation

mrserb
Copy link
Member

@mrserb mrserb commented Dec 7, 2021

Hi all,
This pull request contains a backport of commit 54564388 from the openjdk/jdk repository.
The commit being backported was authored by Yasumasa Suenaga on 23 Mar 2020 and was reviewed by Sergey Bylokhov.

This change tweaks the code to support building using VS2019 which is already supported by the jdk11u.
I can confirm that the build failed before the fix and passed after, but it would be good if existing maintainers of 13u will confirm that the change did not break their environment.u.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/298/head:pull/298
$ git checkout pull/298

Update a local copy of the PR:
$ git checkout pull/298
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/298/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 298

View PR using the GUI difftool:
$ git pr show -t 298

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/298.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 7, 2021

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 545643880c5bf00de850317b4b8c6f85074a2942 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873 Dec 7, 2021
@openjdk
Copy link

openjdk bot commented Dec 7, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Dec 7, 2021

@mrserb This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 2a8557a: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 7, 2021
@mrserb mrserb marked this pull request as ready for review December 8, 2021 00:16
@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 8, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2021

Webrevs

Copy link
Collaborator

@dimitryc dimitryc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Sergey. Sanity checked that it builds with VS2017.

@mrserb
Copy link
Member Author

mrserb commented Dec 8, 2021

/integrate

@openjdk
Copy link

openjdk bot commented Dec 8, 2021

Going to push as commit f4c051e.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 2a8557a: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 8, 2021
@openjdk
Copy link

openjdk bot commented Dec 8, 2021

@mrserb Pushed as commit f4c051e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
2 participants