Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c #299

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Dec 8, 2021

I'd like to backport JDK-8254270 to jdk13u for parity with jdk11u.
The same issue was observed while compiling for the Linux 32 bits platform (compiled with --disable-warnings-as-errors):

/home/ec2-user/workspace/zulu13-build-linux32/zulu-src.git/src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c:82:29: warning: '%s' directive output may be truncated writing up to 56 bytes into a region of size between 52 and 76 [-Wformat-truncation=]
                    "%s.%.3d %s", timestamp_date_time,
                             ^~
                    (int)(millisecs), timestamp_timezone);
                                      ~~~~~~~~~~~~~~~~~~
/home/ec2-user/workspace/zulu13-build-linux32/zulu-src.git/src/jdk.jdwp.agent/share/native/libjdwp/log_messages.c:81:11: note: 'snprintf' output between 6 and 86 bytes into a destination of size 81
     (void)snprintf(tbuf, ltbuf,
           ^~~~~~~~~~~~~~~~~~~~~
                    "%s.%.3d %s", timestamp_date_time,
                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
                    (int)(millisecs), timestamp_timezone);
                    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

After applying this patch the problem has gone. The original patch applied cleanly. All regular tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/299/head:pull/299
$ git checkout pull/299

Update a local copy of the PR:
$ git checkout pull/299
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/299/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 299

View PR using the GUI difftool:
$ git pr show -t 299

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/299.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 8, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 0b7fba75c139bc263cc77c1d29f31703dd88b6f4 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c Dec 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready rfr labels Dec 8, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 8, 2021

Webrevs

@omikhaltsova
Copy link
Contributor Author

@omikhaltsova omikhaltsova commented Dec 8, 2021

/integrate

@openjdk openjdk bot added the sponsor label Dec 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

@omikhaltsova
Your change (at version 03d51ef) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Dec 8, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

Going to push as commit 2a8557a.

@openjdk openjdk bot closed this Dec 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Dec 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 8, 2021

@yan-too @omikhaltsova Pushed as commit 2a8557a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants