Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253631: Remove unimplemented CompileBroker methods after JEP-165 #3

Closed
wants to merge 1 commit into from

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Sep 29, 2020

As stated, remove declarations without any implementations.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253631: Remove unimplemented CompileBroker methods after JEP-165

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/3/head:pull/3
$ git checkout pull/3

Reviewed-by: thartmann
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 29, 2020

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 29, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@yan-too The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 29, 2020

Webrevs

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 29, 2020

Mailing list message from Yuri Nesterenko on jdk-updates-dev:

The Skara bots apparently force discussion even for seamlessly applied backport.
It's one thing to fix.
No reviewer in the generated by default pull request.

Let see how about automatically generated backports once we merge...

--yan

On 29.09.2020 13:23, Yuri Nesterenko wrote:

@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Sep 29, 2020

/reviewer credit thartmann

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@yan-too
Reviewer thartmann successfully credited.

@openjdk
Copy link

@openjdk openjdk bot commented Sep 29, 2020

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8253631: Remove unimplemented CompileBroker methods after JEP-165

Reviewed-by: phh, thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 29, 2020
@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 30, 2020

Mailing list message from Yuri Nesterenko on jdk-updates-dev:

Thank you Paul!

Actually this commit should be closer to the original than what we finally have.
I chose it as a perfect example of immutable backport to test the workflow for update release.

Skara team works on SKARA-413 issue to iron that. In the meantime, I'm going to close this
Github pull request without merge and just push the imported change directly
to jdk13u-dev.

--yan

On 29.09.2020 19:08, Paul Hohensee wrote:

@yan-too yan-too closed this Sep 30, 2020
@yan-too yan-too deleted the yan-too:bug_tt_8253631 branch Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants