Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8278416: Crash during execution of ClassInitBarrier test #300

Closed

Conversation

snazarkin
Copy link

@snazarkin snazarkin commented Dec 8, 2021

This is missed aarch64 part of JDK-8227260 (JNI upcalls should bypass class initialization barrier in c2i adapter). It was not implemented in time due to lack of link between 8227260 and 8223173 (Implement fast class initialization checks on AARCH64).

The code is taken from jdk15 and verified with tier1 and ClassInitBarrier.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8278416: Crash during execution of ClassInitBarrier test

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/300/head:pull/300
$ git checkout pull/300

Update a local copy of the PR:
$ git checkout pull/300
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/300/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 300

View PR using the GUI difftool:
$ git pr show -t 300

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/300.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 8, 2021

👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Dec 8, 2021
@mlbridge
Copy link

mlbridge bot commented Dec 8, 2021

Webrevs

Copy link
Member

@AntonKozlov AntonKozlov left a comment

This patch brings exactly the missing part of the JDK-8278416 for aarch64: https://hg.openjdk.java.net/jdk/jdk/rev/cff8aad2593f

@openjdk
Copy link

openjdk bot commented Dec 10, 2021

@snazarkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8278416: Crash during execution of ClassInitBarrier test

Reviewed-by: akozlov, yan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 2149624: 8250605: Linux x86_32 builds fail after JDK-8249821
  • ee32625: 8249821: Separate libharfbuzz from libfontmanager
  • f4c051e: 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873
  • 2a8557a: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 10, 2021
@snazarkin
Copy link
Author

snazarkin commented Dec 10, 2021

/integrate

@openjdk openjdk bot added the sponsor label Dec 10, 2021
@openjdk
Copy link

openjdk bot commented Dec 10, 2021

@snazarkin
Your change (at version 81df859) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Dec 10, 2021

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 10, 2021

Going to push as commit b522540.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 2149624: 8250605: Linux x86_32 builds fail after JDK-8249821
  • ee32625: 8249821: Separate libharfbuzz from libfontmanager
  • f4c051e: 8241087: Build failure with VS 2019 (16.5.0) due to C2039 and C2873
  • 2a8557a: 8254270: linux 32 bit build doesn't compile libjdwp/log_messages.c

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Dec 10, 2021
@openjdk
Copy link

openjdk bot commented Dec 10, 2021

@yan-too @snazarkin Pushed as commit b522540.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated
3 participants