-
Notifications
You must be signed in to change notification settings - Fork 28
8278416: Crash during execution of ClassInitBarrier test #300
Conversation
👋 Welcome back snazarki! A progress list of the required criteria for merging this PR into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This patch brings exactly the missing part of the JDK-8278416 for aarch64: https://hg.openjdk.java.net/jdk/jdk/rev/cff8aad2593f
@snazarkin This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@yan-too) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@snazarkin |
/sponsor |
Going to push as commit b522540.
Your commit was automatically rebased without conflicts. |
@yan-too @snazarkin Pushed as commit b522540. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
This is missed aarch64 part of JDK-8227260 (JNI upcalls should bypass class initialization barrier in c2i adapter). It was not implemented in time due to lack of link between 8227260 and 8223173 (Implement fast class initialization checks on AARCH64).
The code is taken from jdk15 and verified with tier1 and ClassInitBarrier.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/300/head:pull/300
$ git checkout pull/300
Update a local copy of the PR:
$ git checkout pull/300
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/300/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 300
View PR using the GUI difftool:
$ git pr show -t 300
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/300.diff