Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8250894: Provide a configure option to build and run against the platform libharfbuzz #303

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Dec 10, 2021

I'd like to backport JDK-8250894 to jdk13u for parity with jdk11u.
The original patch applies almost cleanly except the 2 files because of the locations' differences:

  1. make/lib/Awt2dLibraries.gmk instead of make/modules/java.desktop/lib/Awt2dLibraries.gmk;
  2. make/copy/Copy-java.desktop.gmk instead of make/modules/java.desktop/Copy.gmk

No regressions in tests.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8250894: Provide a configure option to build and run against the platform libharfbuzz

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/303/head:pull/303
$ git checkout pull/303

Update a local copy of the PR:
$ git checkout pull/303
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/303/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 303

View PR using the GUI difftool:
$ git pr show -t 303

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/303.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 10, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 84e397b4de6495caa8bbd5d5481305f0bf3e9d06 8250894: Provide a configure option to build and run against the platform libharfbuzz Dec 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 10, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 10, 2021
@omikhaltsova omikhaltsova marked this pull request as ready for review Dec 13, 2021
@openjdk openjdk bot added the rfr label Dec 13, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 13, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Dec 13, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8250894: Provide a configure option to build and run against the platform libharfbuzz

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • b522540: 8278416: Crash during execution of ClassInitBarrier test

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dimitryc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 13, 2021
@omikhaltsova
Copy link
Contributor Author

@omikhaltsova omikhaltsova commented Dec 13, 2021

/integrate

@openjdk openjdk bot added the sponsor label Dec 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 13, 2021

@omikhaltsova
Your change (at version 298e4bb) is now ready to be sponsored by a Committer.

@dimitryc
Copy link
Collaborator

@dimitryc dimitryc commented Dec 13, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 13, 2021

Going to push as commit 58ecfb8.
Since your change was applied there has been 1 commit pushed to the master branch:

  • b522540: 8278416: Crash during execution of ClassInitBarrier test

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot closed this Dec 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr sponsor labels Dec 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 13, 2021

@dimitryc @omikhaltsova Pushed as commit 58ecfb8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants