-
Notifications
You must be signed in to change notification settings - Fork 28
8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux #304
Conversation
👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
/issue add JDK-8272332 |
@omikhaltsova |
@omikhaltsova This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dimitryc) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@omikhaltsova |
/sponsor |
Going to push as commit 828454c. |
@dimitryc @omikhaltsova Pushed as commit 828454c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I'd like to backport JDK-8255790 to jdk13u for parity with jdk11u. It's a follow-up for JDK-8249821.
The backport for
JDK-8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790
was included as a part of this patch.
The original patch applied manually because the file has another location:
make/lib/Awt2dLibraries.gmk instead of make/modules/java.desktop/lib/Awt2dLibraries.gmk.
This patch is very similar to those ones applied to jdk11u and jdk15u.
The crash was reproduced on Fedora Linux 35 with a test app from JDK-8272149. After applying this patch it is fixed.
(the build was with --with-freetype=system)
All regular tests passed.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/304/head:pull/304
$ git checkout pull/304
Update a local copy of the PR:
$ git checkout pull/304
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/304/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 304
View PR using the GUI difftool:
$ git pr show -t 304
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/304.diff