Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux #304

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Dec 14, 2021

I'd like to backport JDK-8255790 to jdk13u for parity with jdk11u. It's a follow-up for JDK-8249821.

The backport for
JDK-8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790
was included as a part of this patch.

The original patch applied manually because the file has another location:
make/lib/Awt2dLibraries.gmk instead of make/modules/java.desktop/lib/Awt2dLibraries.gmk.
This patch is very similar to those ones applied to jdk11u and jdk15u.

The crash was reproduced on Fedora Linux 35 with a test app from JDK-8272149. After applying this patch it is fixed.
(the build was with --with-freetype=system)

All regular tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issues

  • JDK-8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
  • JDK-8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/304/head:pull/304
$ git checkout pull/304

Update a local copy of the PR:
$ git checkout pull/304
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/304/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 304

View PR using the GUI difftool:
$ git pr show -t 304

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/304.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 14, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 05fe06a6bafc089c6466ccbdea335e5dbfdaf335 8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux Dec 14, 2021
@openjdk
Copy link

openjdk bot commented Dec 14, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Dec 14, 2021
@omikhaltsova omikhaltsova marked this pull request as ready for review December 15, 2021 18:42
@omikhaltsova
Copy link
Contributor Author

/issue add JDK-8272332

@openjdk openjdk bot added the rfr Pull request is ready for review label Dec 15, 2021
@openjdk
Copy link

openjdk bot commented Dec 15, 2021

@omikhaltsova
Adding additional issue to issue list: 8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790.

@mlbridge
Copy link

mlbridge bot commented Dec 15, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Dec 16, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255790: GTKL&F: Java 16 crashes on initialising GTKL&F on Manjaro Linux
8272332: --with-harfbuzz=system doesn't add -lharfbuzz after JDK-8255790

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dimitryc) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 16, 2021
@omikhaltsova
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Dec 16, 2021
@openjdk
Copy link

openjdk bot commented Dec 16, 2021

@omikhaltsova
Your change (at version 7336ecc) is now ready to be sponsored by a Committer.

@dimitryc
Copy link
Collaborator

/sponsor

@openjdk
Copy link

openjdk bot commented Dec 16, 2021

Going to push as commit 828454c.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 16, 2021
@openjdk openjdk bot closed this Dec 16, 2021
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Dec 16, 2021
@openjdk
Copy link

openjdk bot commented Dec 16, 2021

@dimitryc @omikhaltsova Pushed as commit 828454c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants