-
Notifications
You must be signed in to change notification settings - Fork 28
8065704: Set LC_ALL=C for all relevant commands in the build system #309
Conversation
👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@omikhaltsova This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
@omikhaltsova |
/sponsor |
Going to push as commit 88667e4. |
@yan-too @omikhaltsova Pushed as commit 88667e4. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
I'd like to backport JDK-8065704 to jdk13u.
I observed warnings related to the locale settings during the build on linux aarch64. After applying this patch their numbers reduced (1000+ -> 17).
The original patch applied cleanly.
All regular tests passed.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/309/head:pull/309
$ git checkout pull/309
Update a local copy of the PR:
$ git checkout pull/309
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/309/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 309
View PR using the GUI difftool:
$ git pr show -t 309
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/309.diff