Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8065704: Set LC_ALL=C for all relevant commands in the build system #309

Closed
wants to merge 1 commit into from

Conversation

omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Dec 29, 2021

I'd like to backport JDK-8065704 to jdk13u.
I observed warnings related to the locale settings during the build on linux aarch64. After applying this patch their numbers reduced (1000+ -> 17).
The original patch applied cleanly.
All regular tests passed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8065704: Set LC_ALL=C for all relevant commands in the build system

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/309/head:pull/309
$ git checkout pull/309

Update a local copy of the PR:
$ git checkout pull/309
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/309/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 309

View PR using the GUI difftool:
$ git pr show -t 309

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/309.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Dec 29, 2021

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 54a3efc82980456fc6d8b00cfcb4aa4c786793be 8065704: Set LC_ALL=C for all relevant commands in the build system Dec 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 29, 2021

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Dec 29, 2021

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8065704: Set LC_ALL=C for all relevant commands in the build system

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the ready label Dec 29, 2021
@omikhaltsova omikhaltsova marked this pull request as ready for review Dec 29, 2021
@openjdk openjdk bot added the rfr label Dec 29, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Dec 29, 2021

Webrevs

@omikhaltsova
Copy link
Contributor Author

@omikhaltsova omikhaltsova commented Dec 29, 2021

/integrate

@openjdk openjdk bot added the sponsor label Dec 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 29, 2021

@omikhaltsova
Your change (at version 420bc0d) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Dec 29, 2021

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Dec 29, 2021

Going to push as commit 88667e4.

@openjdk openjdk bot added the integrated label Dec 29, 2021
@openjdk openjdk bot closed this Dec 29, 2021
@openjdk openjdk bot removed ready rfr sponsor labels Dec 29, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Dec 29, 2021

@yan-too @omikhaltsova Pushed as commit 88667e4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
2 participants