8275610: C2: Object field load floats above its null check resulting in a segfault

[yan-too]

This backport of a crash fix is not exactly clean. Two options different in two passes of the test are not supported in 13u and 15u as well as "randomness" key in the test. Running the test without jtreg consistently does crash VM before the fix.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8275610: C2: Object field load floats above its null check resulting in a segfault

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/312/head:pull/312
$ git checkout pull/312

Update a local copy of the PR:
$ git checkout pull/312
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/312/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 312

View PR using the GUI difftool:
$ git pr show -t 312

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/312.diff

[bridgekeeper]

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (91f88d49)

[phohensee]

Lgtm.

[openjdk]

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8275610: C2: Object field load floats above its null check resulting in a segfault

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[yan-too]

Thank you, Paul! I didn't push at once trying to find why jtreg worked on jdk17 but not in 13/15 -- but that seems to be a separate exercise.

[yan-too]

/integrate

[openjdk]

Going to push as commit 8d0d215.

[openjdk]

@yan-too Pushed as commit 8d0d215.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.