Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8255255: Update Apache Santuario (XML Signature) to version 2.2.1 #319

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Jan 27, 2022

The massive update patch applies cleanly to 13u after prerequisites added. Regression tests do pass; more serious testing with real-life applications will be done in due time after integration.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8255255: Update Apache Santuario (XML Signature) to version 2.2.1

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/319/head:pull/319
$ git checkout pull/319

Update a local copy of the PR:
$ git checkout pull/319
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/319/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 319

View PR using the GUI difftool:
$ git pr show -t 319

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/319.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 27, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cb742f956078f420be328d7899fcba768939020f 8255255: Update Apache Santuario (XML Signature) to version 2.2.1 Jan 27, 2022
@openjdk
Copy link

openjdk bot commented Jan 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jan 27, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 27, 2022

Webrevs

Copy link
Collaborator

@bae bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have compared the proposed change with 15u, where we already have the update to 2.2.1.
The only observed difference is OOM messages in UnsyncByteArrayOutputStream.java which were introduced in 15u as a part of the fix for 8230744.

So, the proposed change looks fine to me.

@openjdk
Copy link

openjdk bot commented Jan 28, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255255: Update Apache Santuario (XML Signature) to version 2.2.1

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 28, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jan 28, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 28, 2022

Going to push as commit aead455.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 28, 2022
@openjdk openjdk bot closed this Jan 28, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 28, 2022
@openjdk
Copy link

openjdk bot commented Jan 28, 2022

@yan-too Pushed as commit aead455.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the sa8255255 branch January 28, 2022 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
2 participants