Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8280947: Adapt test/jdk/javax/xml/crypto/dsig/LogParameters.java for 13u #321

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Jan 31, 2022

Original test depends on JDK-8243010. We have no plans so far to backport the enhancement.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8280947: Adapt test/jdk/javax/xml/crypto/dsig/LogParameters.java for 13u

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/321/head:pull/321
$ git checkout pull/321

Update a local copy of the PR:
$ git checkout pull/321
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/321/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 321

View PR using the GUI difftool:
$ git pr show -t 321

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/321.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 31, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 31, 2022
@mlbridge
Copy link

mlbridge bot commented Jan 31, 2022

Webrevs

Copy link
Collaborator

@bae bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK.

@openjdk
Copy link

openjdk bot commented Jan 31, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8280947: Adapt test/jdk/javax/xml/crypto/dsig/LogParameters.java for 13u

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 43ebdb3: 8280414: Memory leak in DefaultProxySelector

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 31, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jan 31, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jan 31, 2022

Going to push as commit 7d6e6ba.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 43ebdb3: 8280414: Memory leak in DefaultProxySelector

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jan 31, 2022
@openjdk openjdk bot closed this Jan 31, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 31, 2022
@openjdk
Copy link

openjdk bot commented Jan 31, 2022

@yan-too Pushed as commit 7d6e6ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the fx8280947 branch February 1, 2022 06:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
integrated Pull request has been integrated
2 participants