-
Notifications
You must be signed in to change notification settings - Fork 28
8249867: XML declaration is not followed by a newline #328
Conversation
👋 Welcome back yan! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks fine to me.
Thanks,
Andrew
@yan-too This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
/integrate |
Going to push as commit b9c0ba8. |
Backport of this change differs from the original in copyright dates/lastchanged comments and a list of bugs in the test. We need this fix to be on par with LTS releases. Required CSR is approved.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/328/head:pull/328
$ git checkout pull/328
Update a local copy of the PR:
$ git checkout pull/328
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/328/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 328
View PR using the GUI difftool:
$ git pr show -t 328
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/328.diff