Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8249867: XML declaration is not followed by a newline #328

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Feb 16, 2022

Backport of this change differs from the original in copyright dates/lastchanged comments and a list of bugs in the test. We need this fix to be on par with LTS releases. Required CSR is approved.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8249867: XML declaration is not followed by a newline
  • JDK-8259352: Documenting the implementation specific features and properties (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/328/head:pull/328
$ git checkout pull/328

Update a local copy of the PR:
$ git checkout pull/328
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/328/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 328

View PR using the GUI difftool:
$ git pr show -t 328

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/328.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 16, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 69ee314b63a9f260e3dcbe9ccd67ddc4faec3ba0 8249867: XML declaration is not followed by a newline Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 16, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 16, 2022

Webrevs

Copy link
Collaborator

@bae bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks fine to me.

Thanks,
Andrew

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8249867: XML declaration is not followed by a newline

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 16, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Feb 16, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Feb 16, 2022

Going to push as commit b9c0ba8.

@openjdk openjdk bot added the integrated Pull request has been integrated label Feb 16, 2022
@openjdk openjdk bot closed this Feb 16, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Feb 16, 2022
@openjdk
Copy link

openjdk bot commented Feb 16, 2022

@yan-too Pushed as commit b9c0ba8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8249867 branch February 16, 2022 12:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants