Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.
/ jdk13u-dev Public archive

8276141: XPathFactory set/getProperty method #329

Closed
wants to merge 3 commits into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Feb 17, 2022

Difference against the original: no LastModified in XPathFactoryImpl.java in 13/15; the test patch manually applied.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8276141: XPathFactory set/getProperty method
  • JDK-8276143: Add XPathFactory setProperty and getProperty methods (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/329/head:pull/329
$ git checkout pull/329

Update a local copy of the PR:
$ git checkout pull/329
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/329/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 329

View PR using the GUI difftool:
$ git pr show -t 329

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/329.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Feb 17, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b226ab99c872e791d3ed9fca015cf92847904c34 8276141: XPathFactory set/getProperty method Feb 17, 2022
@openjdk
Copy link

openjdk bot commented Feb 17, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Feb 17, 2022
@mlbridge
Copy link

mlbridge bot commented Feb 17, 2022

Webrevs

Copy link
Collaborator

@bae bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed change looks fine.

Thanks,
Andrew

@openjdk
Copy link

openjdk bot commented Feb 24, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8276141: XPathFactory set/getProperty method

Reviewed-by: bae, goetz

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Feb 24, 2022
Copy link
Member

@GoeLin GoeLin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bae bae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@yan-too
Copy link
Collaborator Author

yan-too commented Mar 4, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Mar 4, 2022

Going to push as commit 4b2f75b.

@openjdk openjdk bot added the integrated Pull request has been integrated label Mar 4, 2022
@openjdk openjdk bot closed this Mar 4, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Mar 4, 2022
@openjdk
Copy link

openjdk bot commented Mar 4, 2022

@yan-too Pushed as commit 4b2f75b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8276141 branch March 4, 2022 09:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants