Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

Conversation

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 1, 2022

Should backport this to keep data up to date and close to other releases.
First series of tests run OK.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/335/head:pull/335
$ git checkout pull/335

Update a local copy of the PR:
$ git checkout pull/335
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/335/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 335

View PR using the GUI difftool:
$ git pr show -t 335

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/335.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 1, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 7ce75afbbcca7635356c7377be7ddff15335e563 8255266: Update Public Suffix List to 3c213aa Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8255266: Update Public Suffix List to 3c213aa

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Apr 1, 2022

/integrate

@mlbridge
Copy link

mlbridge bot commented Apr 1, 2022

Webrevs

@openjdk
Copy link

openjdk bot commented Apr 1, 2022

Going to push as commit bac9974.

@openjdk openjdk bot added the integrated Pull request has been integrated label Apr 1, 2022
@openjdk openjdk bot closed this Apr 1, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Apr 1, 2022
@openjdk
Copy link

openjdk bot commented Apr 1, 2022

@yan-too Pushed as commit bac9974.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8255266 branch April 1, 2022 14:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

backport clean integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant