Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8193682: Infinite loop in ZipOutputStream.close() #337

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 4, 2022

This fix to the infinite loop in ZipOutputStream.close() is applicable to 13u (and the regtest promptly fails here). CSR is required and provided (thank you Goetz!). Zip tests are OK after the fix, the nightly is running.
I have to use old format for switch: switch expressions are in preview mode in 13, and replaced code hasn't them anyway. Thus, review is necessary.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed
  • Change requires a CSR request to be approved

Issues

  • JDK-8193682: Infinite loop in ZipOutputStream.close()
  • JDK-8276305: Infinite loop in ZipOutputStream.close() (CSR)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/337/head:pull/337
$ git checkout pull/337

Update a local copy of the PR:
$ git checkout pull/337
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/337/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 337

View PR using the GUI difftool:
$ git pr show -t 337

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/337.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Apr 4, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 1e9ed54d362b8c57be5fbbac2de5afbd0f05435f 8193682: Infinite loop in ZipOutputStream.close() Apr 4, 2022
@openjdk
Copy link

openjdk bot commented Apr 4, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Apr 4, 2022
@mlbridge
Copy link

mlbridge bot commented Apr 4, 2022

Webrevs

bae
bae approved these changes Apr 6, 2022
Copy link
Collaborator

@bae bae left a comment

The change looks fine to me.

Thanks,
Andrew

@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8193682: Infinite loop in ZipOutputStream.close()

Reviewed-by: bae

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 6, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Apr 6, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Apr 6, 2022

Going to push as commit 7da3cd1.

@openjdk openjdk bot added the integrated label Apr 6, 2022
@openjdk openjdk bot closed this Apr 6, 2022
@openjdk openjdk bot removed ready rfr labels Apr 6, 2022
@openjdk
Copy link

openjdk bot commented Apr 6, 2022

@yan-too Pushed as commit 7da3cd1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8193682 branch Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants