Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273682: Upgrade Jline to 3.20.0 #342

Closed
wants to merge 1 commit into from
Closed

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 22, 2022

Clean backport for parity with major releases. Tier1 and jline tests run well.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/342/head:pull/342
$ git checkout pull/342

Update a local copy of the PR:
$ git checkout pull/342
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/342/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 342

View PR using the GUI difftool:
$ git pr show -t 342

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/342.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 22, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport b8cb76ad210cb3e7524c7f5b13cfe57746ac05d4 8273682: Upgrade Jline to 3.20.0 Apr 22, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273682: Upgrade Jline to 3.20.0

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready rfr labels Apr 22, 2022
@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Apr 22, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2022

Going to push as commit d917614.

@openjdk openjdk bot added the integrated label Apr 22, 2022
@openjdk openjdk bot closed this Apr 22, 2022
@openjdk openjdk bot removed ready rfr labels Apr 22, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 22, 2022

@yan-too Pushed as commit d917614.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8273682 branch Apr 22, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 22, 2022

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated
1 participant