8273826: Correct Manifest file name and NPE checks #344
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
I need to backport this fix for parity with other releases and as a part of backports chain. Some context adjustments were necessary. The relevant tests run fine.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/344/head:pull/344
$ git checkout pull/344
Update a local copy of the PR:
$ git checkout pull/344
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/344/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 344
View PR using the GUI difftool:
$ git pr show -t 344
Using diff file
Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/344.diff