Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8273826: Correct Manifest file name and NPE checks #344

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Apr 27, 2022

I need to backport this fix for parity with other releases and as a part of backports chain. Some context adjustments were necessary. The relevant tests run fine.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8273826: Correct Manifest file name and NPE checks

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/344/head:pull/344
$ git checkout pull/344

Update a local copy of the PR:
$ git checkout pull/344
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/344/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 344

View PR using the GUI difftool:
$ git pr show -t 344

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/344.diff

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Apr 27, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 03a8d342b86e720d3cba08d540182b4ab161fba3 8273826: Correct Manifest file name and NPE checks Apr 27, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr labels Apr 27, 2022
@mlbridge
Copy link

@mlbridge mlbridge bot commented Apr 27, 2022

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Apr 27, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8273826: Correct Manifest file name and NPE checks

Reviewed-by: dcherepanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 9f83fa1: 8282538: PKCS11 tests fail on CentOS Stream 9

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Apr 27, 2022
@yan-too
Copy link
Collaborator Author

@yan-too yan-too commented Apr 28, 2022

/integrate

@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2022

Going to push as commit f9b153a.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 9f83fa1: 8282538: PKCS11 tests fail on CentOS Stream 9

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated label Apr 28, 2022
@openjdk openjdk bot closed this Apr 28, 2022
@openjdk openjdk bot removed ready rfr labels Apr 28, 2022
@openjdk
Copy link

@openjdk openjdk bot commented Apr 28, 2022

@yan-too Pushed as commit f9b153a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the bp8273826 branch Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated
2 participants