Skip to content
This repository was archived by the owner on Feb 2, 2023. It is now read-only.

8241271: Make hotspot build reproducible #356

Closed
wants to merge 1 commit into from

Conversation

apavlyutkin
Copy link
Contributor

@apavlyutkin apavlyutkin commented Jun 7, 2022

Hi! Here is the backport of 8241271: Make hotspot build reproducible. The original patch applied cleanly.

Verification:

  • 20.04LTS/GCC9.4: bash configure --with-boot-jdk=/opt/jdk-13 --with-hotspot-build-time="6/7/2022 11:35am" --with-extra-cflags="-Werror=date-time" --with-extra-cxxflags="-Werror=date-time" && make all - whole build PASSES
  • Windows/MSVS2019: bash ./configure --with-boot-jdk=../boot-jdk/jdk-13 --with-hotspot-build-time="2022-06-7 10:57am" --with-extra-cflags="/experimental:deterministic" --with-extra-cxxflags="/experimental:deterministic" - Hotspot build PASSES, then an error in jdk.jdi (8287894 raised against the issue)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/356/head:pull/356
$ git checkout pull/356

Update a local copy of the PR:
$ git checkout pull/356
$ git pull https://git.openjdk.java.net/jdk13u-dev pull/356/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 356

View PR using the GUI difftool:
$ git pr show -t 356

Using diff file

Download this PR as a diff file:
https://git.openjdk.java.net/jdk13u-dev/pull/356.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 7, 2022

👋 Welcome back apavlyutkin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@apavlyutkin apavlyutkin changed the title Backport-of: 901029355f51c8faaa841dfee1e2e15175a6402e Backport 901029355f51c8faaa841dfee1e2e15175a6402e Jun 7, 2022
@openjdk openjdk bot changed the title Backport 901029355f51c8faaa841dfee1e2e15175a6402e 8241271: Make hotspot build reproducible Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@apavlyutkin This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8241271: Make hotspot build reproducible

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 7, 2022
@mlbridge
Copy link

mlbridge bot commented Jun 7, 2022

Webrevs

@apavlyutkin
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@apavlyutkin
Your change (at version 7e9f2ac) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

yan-too commented Jun 7, 2022

/sponsor

@openjdk
Copy link

openjdk bot commented Jun 7, 2022

Going to push as commit 1299fde.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 7, 2022
@openjdk openjdk bot closed this Jun 7, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jun 7, 2022
@openjdk
Copy link

openjdk bot commented Jun 7, 2022

@yan-too @apavlyutkin Pushed as commit 1299fde.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants