Skip to content
This repository has been archived by the owner on Feb 2, 2023. It is now read-only.

8238380: java.base/unix/native/libjava/childproc.c "multiple definition" link errors with GCC10 #360

Closed
wants to merge 1 commit into from

Conversation

yan-too
Copy link
Collaborator

@yan-too yan-too commented Jun 14, 2022

need to backport this fix to 13u, too. Clean barring one copyright digit.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8238380: java.base/unix/native/libjava/childproc.c "multiple definition" link errors with GCC10

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk13u-dev pull/360/head:pull/360
$ git checkout pull/360

Update a local copy of the PR:
$ git checkout pull/360
$ git pull https://git.openjdk.org/jdk13u-dev pull/360/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 360

View PR using the GUI difftool:
$ git pr show -t 360

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk13u-dev/pull/360.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 14, 2022

👋 Welcome back yan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport a59e8a7f6fed2accd1034eebf16545ef78c3ea1b 8238380: java.base/unix/native/libjava/childproc.c "multiple definition" link errors with GCC10 Jun 14, 2022
@openjdk
Copy link

openjdk bot commented Jun 14, 2022

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Jun 14, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jun 14, 2022

/clean

@openjdk openjdk bot added the clean label Jun 14, 2022
@openjdk
Copy link

openjdk bot commented Jun 14, 2022

@yan-too This backport pull request is now marked as clean

@openjdk
Copy link

openjdk bot commented Jun 14, 2022

@yan-too This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8238380: java.base/unix/native/libjava/childproc.c "multiple definition" link errors with GCC10

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 14, 2022
@yan-too
Copy link
Collaborator Author

yan-too commented Jun 14, 2022

/integrate

@openjdk
Copy link

openjdk bot commented Jun 14, 2022

Going to push as commit 16e304d.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 14, 2022
@openjdk openjdk bot closed this Jun 14, 2022
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 14, 2022
@openjdk
Copy link

openjdk bot commented Jun 14, 2022

@yan-too Pushed as commit 16e304d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@yan-too yan-too deleted the gcc8238380 branch June 14, 2022 14:08
@mlbridge
Copy link

mlbridge bot commented Jun 14, 2022

Webrevs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
backport clean integrated Pull request has been integrated
1 participant