Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8235183: Remove the "HACK CODE" in comment #37

Closed
wants to merge 1 commit into from
Closed

8235183: Remove the "HACK CODE" in comment #37

wants to merge 1 commit into from

Conversation

@omikhaltsova
Copy link
Contributor

@omikhaltsova omikhaltsova commented Nov 27, 2020

I'd like to backport JDK-8235183 to jdk13u for parity with jdk11.
There is modification only in comments.
The original patch applied cleanly.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Download

$ git fetch https://git.openjdk.java.net/jdk13u-dev pull/37/head:pull/37
$ git checkout pull/37

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Nov 27, 2020

👋 Welcome back omikhaltcova! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 50714b0fb9fd4391385eda3af89582dd3fb5a5f1 8235183: Remove the "HACK CODE" in comment Nov 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@omikhaltsova This change now passes all automated pre-integration checks.

After integration, the commit message for the final commit will be:

8235183: Remove the "HACK CODE" in comment

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@mlbridge
Copy link

@mlbridge mlbridge bot commented Nov 27, 2020

Webrevs

@omikhaltsova
Copy link
Contributor Author

@omikhaltsova omikhaltsova commented Nov 27, 2020

/integrate

@openjdk openjdk bot added the sponsor label Nov 27, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@omikhaltsova
Your change (at version 5b401be) is now ready to be sponsored by a Committer.

@yan-too
Copy link
Collaborator

@yan-too yan-too commented Nov 27, 2020

/sponsor

@openjdk
Copy link

@openjdk openjdk bot commented Nov 27, 2020

@yan-too @omikhaltsova Pushed as commit dabaf4e.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants